Refactor inactive_noinl to inactive for istrans #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May be an alternate resolution to EnzymeAD/Enzyme.jl#2589 probably merits runnign enzyme tests here to confirm it works?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 38 38
Lines 3949 3949
=======================================
Hits 3252 3252
Misses 697 697 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 17824816617Details
💛 - Coveralls |
|
The offending model does work with this PR now (code from #947 (comment)): using DynamicPPL, Distributions
import Enzyme: Enzyme, Forward, Reverse, set_runtime_activity, Const
@model function mc()
x = Vector{Float64}(undef, 5)
x[1] ~ Normal()
x[2] ~ InverseGamma(2, 3)
x[3] ~ truncated(Normal(), -5, 20)
x[4:5] ~ Dirichlet([1.0, 2.0])
end
model = mc()
vi = VarInfo(model)
params = fill(0.5, 5)
function logp(x, model, vi)
varinfo_new = DynamicPPL.unflatten(vi, x)
varinfo_eval = last(DynamicPPL.evaluate!!(model, varinfo_new))
return getlogjoint(varinfo_eval)
end
logp(params, model, vi)
Enzyme.gradient(set_runtime_activity(Forward), logp, params, Const(model), Const(vi))
Enzyme.gradient(set_runtime_activity(Reverse), logp, params, Const(model), Const(vi)) |
|
Will approve once CI passes, thanks @wsmoses! |
penelopeysm
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May be an alternate resolution to EnzymeAD/Enzyme.jl#2589
probably merits runnign enzyme tests here to confirm it works?